Last week when I announced that the contract was fixed in order to prevent similar names, some members contacted with me to show me some examples where the algorithm was not working properly, like 
Hive account@fu1 and 
Hive account@fm1... again, I had to take a pen and paper to determine what was wrong with the algorithm and come up with new ideas to improve the design.
I found that the problem with the algorithm to detect similar names is that I was ordering the names alphabetically, and making comparisons with the closest names in the list... which is not enough!
For instance, let's say the contract already has this list o names: 
Hive account@alice, 
Hive account@alimento, 
Hive account@alitas, and 
Hive account@alligator. And then we try to create the new name 
Hive account@aliwe. If we look closely, Hive account@alice and Hive account@aliwe are very similar, so ideally these 2 words should be compared in order to detect that they are similar. However, the contract was comparing this new word just with Hive account@alitas and Hive account@alligator, because Hive account@aliwe is in the middle of these 2 words if we order them alphabetically. Since Hive account@aliwe is very different to these words then it was accepted.
After thinking about it a lot, I found a solution to the problem.
Unique Patterns
This new approach doesn't order the names alphabetically. Instead of that, from each name we extract a list of patterns, and we make sure that these patterns are unique.
Let's come back to the example of Hive account@alice. When alice is created, the contract saves this list of patterns: lice, aice, alce, alie, alic. These patterns are the result of removing 1 letter from the original name alice. If we remove the first letter we get "lice". If we remove the second letter we get "aice". Alice without the third letter is "alce". Without the fourth letter is "alie". And without the last one is "alic".
The algorithm consists in verify that these patterns are unique for each name in the contract. For instance, if Hive account@aliwe is created, it will be rejected because "alie" is one of its patterns, and this pattern is already saved for alice. Apart from that this verification is done by removing up to 2 letters. For instance, 
Hive account@alicce will be rejected as well because if we remove 2 letters we get again the pattern "alie", which is already taken by alice.
In conclusion, we just have to extract and compare if the patterns already exist. No need to order them alphabetically, or compute the levenshtein distance. Which not only solves the problem we faced with similar names, but also improves the performance of the contract 💪 Koinos Nicknames continues with its mission of SAFE TRANSFERS.
Contract patched
This change represented a complete refactor of the contract. But apart from that, I had to create a plan to rewrite the existing data in the contract in order to apply the new algorithm:
- Remove conflicting names.
- Rebuild patterns for all names and write them in the state of the contract.
- Remove the previous lists dedicated to save the names alphabetically.
I successfully managed to apply the patch. During this process I consumed around 260 MANA! (splitted in several transactions) It's the first time I consume this big amount of mana. As a reference, today a transfer of koin consumes around 0.2 mana. So, this patch consumed the mana of making 1300 koin transfers.
Names removed
As I said, I had to remove some conflicting names after applying the new rules. Sorry for the incovenience. Here is the list of names removed:
Hive account@ggg, 
Hive account@bill, 
Hive account@buick, 
Hive account@open, 
Hive account@toys, 
Hive account@free, 
Hive account@burn, 
Hive account@bull, 
Hive account@tim, 
Hive account@mary, 
Hive account@bren, 
Hive account@olga, 
Hive account@taco, 
Hive account@best, Hive account@fm1, 
Hive account@kk11, 
Hive account@snoop, 
Hive account@bts, 
Hive account@poe, 
Hive account@koins, 
Hive account@teing, 
Hive account@ford, 
Hive account@maria, 
Hive account@jenny, 
Hive account@lol, 
Hive account@zero, 
Hive account@axa, 
Hive account@bitforex, 
Hive account@cmc, 
Hive account@ordi, 
Hive account@diana, 
Hive account@pop, 
Hive account@nbc, 
Hive account@play, 
Hive account@france, 
Hive account@sha, 
Hive account@jeff, 
Hive account@lily, 
Hive account@star, 
Hive account@xoom, 
Hive account@coingate, 
Hive account@space, 
Hive account@sell, 
Hive account@koinos, 
Hive account@my-wallet, 
Hive account@block, 
Hive account@xin, 
Hive account@may, 
Hive account@miner, 
Hive account@mac.
Transaction - a801bad2
Reminder for Hive Users
I put here some reminder for Hive users (more details in the previous post):
If you are in the following list: 
Hive account@gtg, 
Hive account@ezzy, 
Hive account@smooth, 
Hive account@arcange, 
Hive account@yabapmatt, 
Hive account@ausbitbank, 
Hive account@blocktrades, 
Hive account@therealwolf, 
Hive account@splinterlands and you would like to claim your name in Koinos, please reply to this post and put your koinos address 😉 The limit to claim these names is October 28th, 2023. If it is not claimed then it will be released to the initial address that took them.
As a way to prevent further hive account takeovers, I have taken the liberty of reserving some accounts: 
Hive account@peakd, 
Hive account@pfunk, 
Hive account@acidyo, 
Hive account@detlev, 
Hive account@haejin, 
Hive account@aggroed, 
Hive account@asgarth, 
Hive account@edicted, 
Hive account@gadrian, 
Hive account@tarazkp, 
Hive account@bluerobo, 
Hive account@stoodkev, 
Hive account@timcliff, 
Hive account@tobetada, 
Hive account@vimukthi, 
Hive account@buggedout, 
Hive account@fredrikaa, 
Hive account@kevinwong, 
Hive account@mahdiyari, 
Hive account@trafalgar, 
Hive account@transisto, 
Hive account@anomadsoul, 
Hive account@emrebeyler, 
Hive account@good-karma, 
Hive account@lukestokes, 
Hive account@someguy123, 
Hive account@resiliencia, 
Hive account@fulltimegeek, 
Hive account@penguinpablo, 
Hive account@brianoflondon, 
Hive account@lordbutterfly, 
Hive account@theycallmedan, 
Hive account@taskmaster4450, 
Hive account@thecryptodrive. If you are in this list and want to claim your name in koinos please comment as well in the post with your koinos address. In this case there is no time limit.
If your account was not mentioned above check if your name is still available in https://koinosbox.com/nicknames and claim it. It's free:
- Install kondor wallet.
- Go to https://koinosbox.com/nicknames, set your name and click create.
- Add an image, short bio, etc (optional fields) and click register.
- In the popup click "advanced".
- Tick "use free mana" and set max. mana to 10.
- Go down, click check events and send.
- Enjoy your name 😎
The reception at the moment is very good. Now, we have more than 1000 names in the contract.
We are close to the end in order to give 100% control to Koinos Governance. I hope that with this patch we will have a more robust system. If you detect new bugs please let me know.
Support
Please support this development. There are several ways you can contribute:
Join the JGA Mining Pool (very good APY).
Buy a Kondor NFT
Send a donation in https://koinosbox.com/nicknames
Become a sponsor in https://github.com/sponsors/joticajulian
