Hi there, this is great work! You've detailed your work that's good.
Let's go for the review:
Starting with the useless comment war :D
https://github.com/ateufel/knacksteem.org/blob/b1ebe15af3dfb845204619b4c72e765b32c50df4/src/components/Editor/index.js#L195 => You should add the second argument to mapActions instead of using https://github.com/ateufel/knacksteem.org/blob/b1ebe15af3dfb845204619b4c72e765b32c50df4/src/components/Editor/index.js#L97
https://github.com/ateufel/knacksteem.org/blob/b1ebe15af3dfb845204619b4c72e765b32c50df4/src/components/Editor/index.js#L97 => You shouldn't await for the dispatch but have your action send a
ACTION_SUCCESSwhen it's done so that the reducer handles it.Your use of redux and redux action is a bit weird. You should find some documentation / articles.
I sort of expected to see something like this
Aside from the use of redux that I find a bit weird your code is great! Good job on this pull request!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
RE: [KnackSteem] - Edit/Reply for Articles and Comments