Thank you for your contribution. Despiste you are working on your branch rewrite which hasn't been merged yet to the master branch, I would like to give a few cents of my review.
- I notice that your commit messages are sort-of
testingXXX- which doesn't really give much information. - I haven't see any existing unit tests, nor the new tests added while you make changes - which is a bit concern.
- Code not needed should really be deleted instead of commenting-out. For example, here you commented out code, which is hard to understand without comments and especially the commit messages are not descriptive.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
RE: ChatChain: A ChatServices linking API